Skip to content

Fix up deepsource #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 13, 2024
Merged

Fix up deepsource #51

merged 5 commits into from
Jul 13, 2024

Conversation

reactive-firewall
Copy link
Owner

Includes various fixes for deepsource found issues:

@reactive-firewall
Marked early del to ignore false-positives of PYL-C0414 ( - Fixes #48 …
f23e54a 
…- )
@reactive-firewall
Marked early del to ignore false-positives of PYL-W0043 ( - Fixes #47 …
259ffb6 
…- )
@reactive-firewall
refactor to avoid PYL-W0621 ( - Fixes #49 - )
5f11d12
@reactive-firewall
comment to skip false PYL-W0622 ( - Fixes #50 - )
3566cda
@reactive-firewall
Merge branches 'skip-silly-PYL-W0621', 'skip-early-del-PTC-W0043', 's…
03ba956 
…kip-ambiguous-module-PYL-C0414' and 'fix-up-overload-PYL-W0622'

* skip-silly-PYL-W0621:
  refactor to avoid PYL-W0621 ( - Fixes #49 - )

* skip-early-del-PTC-W0043:
  Marked early del to ignore false-positives of PYL-W0043 ( - Fixes #47 - )

* skip-ambiguous-module-PYL-C0414:
  Marked early del to ignore false-positives of PYL-C0414 ( - Fixes #48 - )

* fix-up-overload-PYL-W0622:
  comment to skip false PYL-W0622 ( - Fixes #50 - )
@reactive-firewall reactive-firewall self-assigned this Jul 13, 2024
@github-actions github-actions bot added Python Lang Changes to Python source code Testing Something can be verified CI Continuous Integration Tooling Python Repo Anything Project Related labels Jul 13, 2024
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jul 13, 2024

Here's the code health analysis summary for commits 86d4374..03ba956. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 8 occurences resolved
View Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

This was linked to issues Jul 13, 2024
Ignore false-positives of PTC-W0043 #47
Closed
Ignore false-positives of PYL-C0414 #48
Closed
Fix PYL-W0621 in setup.py #49
Closed
ignore false-positive PYL-W0622 #50
Closed
@reactive-firewall reactive-firewall marked this pull request as ready for review July 13, 2024 04:40
reactive-firewall
reactive-firewall commented Jul 13, 2024
View reviewed changes
Copy link
Owner Author

@reactive-firewall reactive-firewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real functional change; all changes are acceptable.

@reactive-firewall reactive-firewall merged commit 03ba956 into master Jul 13, 2024
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reactive-firewall reactive-firewall

Labels
CI Continuous Integration Tooling Python Lang Changes to Python source code Python Repo Anything Project Related Testing Something can be verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore false-positive PYL-W0622 Fix PYL-W0621 in setup.py Ignore false-positives of PYL-C0414 Ignore false-positives of PTC-W0043
1 participant
@reactive-firewall